Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file on storage termination #219

Merged
merged 2 commits into from
Jun 15, 2021

Conversation

hannahhoward
Copy link
Contributor

Goals

recover hard drive space once a storage deal terminates by deleting the generated file

Implementation

This is definitely a minimal approach, but it should get the job done -- just delete the generated file when the storage deal finishes executing, and clear the Lotus import

For discussion

For a succesful deal, this won't delete until the deal goes to StorageDealActive, which can be a long time. Technically, we could delete it sooner. Is it important to add code to check for the state when the data transfer is open and delete it then (StorageDealCheckForAcceptance)

recover hard drive space once a storage deal terminates by deleting the generated file
@hannahhoward hannahhoward force-pushed the feat/remove-file-on-deal-termination branch from 56af71f to 88c0bc6 Compare June 15, 2021 01:47
@hannahhoward hannahhoward merged commit df03d9f into main Jun 15, 2021
@hannahhoward hannahhoward deleted the feat/remove-file-on-deal-termination branch June 15, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants